Check for missing options / databaseURL on emulator start #1016
Conversation
taeold
left a comment
taeold
left a comment
There was a problem hiding this comment.
Thank you for your great contribution!
Can you add an entry in the CHANGELOG to describe the bug fix?
taeold
left a comment
taeold
left a comment
There was a problem hiding this comment.
One more change and we should 🚢
Co-authored-by: Daniel Lee <taeold@gmail.com>
|
No problem. |
|
@Hoppi164 It looks like the linter is failing - can you run |
|
Hi @taeold I've run format:fix and removed the extra spacing i had on the (note: there was a few other lint warnings in unrelated files, i've not corrected these as it seems out-of-scope for this PR) |
|
lgtm - thank you for your contribution (and your patience!) |
|
No problem at all! |
2 participants
Description
Bug Fix
When using firebase emulators Realtime Database throws an error due to app.options not existing.
I've found adding an extra check to the database constructor stops this error, and results in the emulator starting up correctly.
Code sample
Instead of
if (app && app.options.databaseURL.startsWith('http:'))I've added
if ( app && app.options && app.options.databaseURL && app.options.databaseURL.startsWith('http:') )Note: I've deliberately not used the modern ES6 optional chaining.
This syntax would be much cleaner, but is not supported by your lowest node version.
app?.options?.databaseURL?.startsWith('http:')